chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor #16999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16999 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 1030 1030
Lines 55031 55033 +2
Branches 7465 7465
=======================================
+ Hits 42336 42340 +4
+ Misses 12441 12439 -2
Partials 254 254
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgabryje
approved these changes
Oct 7, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…apache#16999) * chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor * putting the background back in, but using the theme. * should be no need for this import anymore.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…apache#16999) * chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor * putting the background back in, but using the theme. * should be no need for this import anymore.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The SqlEditor had two small issues with some CSS that this PR corrects:
supersetThemeinstead of pulling it in via theThemeProvideras is preferred.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No difference.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION