Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(filterset): improve response body #16974

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Oct 5, 2021

  1. I was asked to add id into the response
  2. it is no sense to send back the client the object has just sent, better to return the new created/updated object

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #16974 (4cfa594) into master (9a8911f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16974   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files        1030     1030           
  Lines       55017    55017           
  Branches     7464     7464           
=======================================
  Hits        42282    42282           
  Misses      12482    12482           
  Partials      253      253           
Flag Coverage Δ
hive 81.44% <100.00%> (ø)
mysql 81.83% <100.00%> (ø)
postgres 81.89% <100.00%> (ø)
python 82.24% <100.00%> (ø)
sqlite 81.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/filter_sets/api.py 97.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8911f...4cfa594. Read the comment docs.

@ofekisr ofekisr changed the title chore(filterset) improve response body chore(filterset): improve response body Oct 6, 2021
@ofekisr ofekisr changed the title chore(filterset): improve response body chore(filterset): improve response body k Oct 6, 2021
@ofekisr ofekisr changed the title chore(filterset): improve response body k refactor(filterset): improve response body Oct 6, 2021
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitmiran137 amitmiran137 reopened this Oct 7, 2021
@amitmiran137 amitmiran137 merged commit 5fc9970 into apache:master Oct 7, 2021
@ofekisr ofekisr deleted the chore/filterset_improve_data_response branch October 10, 2021 09:16
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants