-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Dashboard): Implement dedicated message for missing dataset #16959
Conversation
LGTM! Thanks for the improvement! |
Codecov Report
@@ Coverage Diff @@
## master #16959 +/- ##
==========================================
- Coverage 76.70% 76.70% -0.01%
==========================================
Files 1030 1031 +1
Lines 55056 55091 +35
Branches 7465 7475 +10
==========================================
+ Hits 42231 42257 +26
- Misses 12576 12585 +9
Partials 249 249
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ache#16959) * Implement dedicated message * Clean up
…ache#16959) * Implement dedicated message * Clean up
SUMMARY
Implements a dedicated "Missing dataset" message to replace the generic "Unexpected error".
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION