Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pylint): Reenable too-many-lines check #16287

Conversation

john-bodley
Copy link
Member

SUMMARY

Re-enabling the Pylint too-many-lines check.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #16287 (7bd0b71) into master (c6ac107) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 7bd0b71 differs from pull request most recent head 18c1274. Consider uploading reports for the commit 18c1274 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16287      +/-   ##
==========================================
- Coverage   76.93%   76.80%   -0.14%     
==========================================
  Files        1007     1007              
  Lines       54108    54108              
  Branches     7344     7344              
==========================================
- Hits        41629    41558      -71     
- Misses      12239    12310      +71     
  Partials      240      240              
Flag Coverage Δ
hive ?
mysql 81.64% <ø> (-0.04%) ⬇️
postgres 81.74% <ø> (+0.03%) ⬆️
presto 81.57% <ø> (+0.03%) ⬆️
python 81.99% <ø> (-0.26%) ⬇️
sqlite 81.31% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/api.py 85.82% <ø> (ø)
superset/charts/schemas.py 100.00% <ø> (ø)
superset/config.py 91.41% <ø> (ø)
superset/connectors/sqla/models.py 89.46% <ø> (-0.24%) ⬇️
superset/databases/api.py 92.95% <ø> (ø)
superset/db_engine_specs/base.py 88.39% <ø> (ø)
superset/db_engine_specs/presto.py 89.95% <ø> (-0.42%) ⬇️
superset/examples/countries.py 0.00% <ø> (ø)
superset/security/manager.py 91.84% <ø> (ø)
superset/utils/core.py 89.76% <ø> (-0.13%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ac107...18c1274. Read the comment docs.

@john-bodley john-bodley force-pushed the john-bodley--pylint-reenable-too-many-lines branch from 5ed79e0 to fd488c8 Compare August 18, 2021 19:18
@john-bodley john-bodley force-pushed the john-bodley--pylint-reenable-too-many-lines branch 4 times, most recently from 15ae85c to cda9542 Compare August 23, 2021 20:13
@john-bodley john-bodley force-pushed the john-bodley--pylint-reenable-too-many-lines branch from b81bf51 to 18c1274 Compare September 13, 2021 18:27
@john-bodley john-bodley merged commit 1669947 into apache:master Sep 13, 2021
@john-bodley john-bodley deleted the john-bodley--pylint-reenable-too-many-lines branch September 13, 2021 20:55
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants