chore: remove unnecessary deps #15787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
changed the title
Codecov Report
@@ Coverage Diff @@
## master #15787 +/- ##
==========================================
+ Coverage 77.05% 77.17% +0.11%
==========================================
Files 984 984
Lines 51650 52365 +715
Branches 6991 6991
==========================================
+ Hits 39801 40414 +613
- Misses 11625 11727 +102
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
force-pushed
the
remove_old_deps
branch
2 times, most recently
from
f7414ef to
01d9b6b
Compare
betodealmeida
commented
Jul 20, 2021
Comment on lines
-116
to
-117
| "pyparsing>=2.4.7, <3.0.0", | ||
| "holidays==0.10.3", # PINNED! https://github.com/dr-prodigy/python-holidays/issues/406 | ||
| "deprecation>=2.1.0, <2.2.0", |
There was a problem hiding this comment.
These are duplicates, see lines 99, 88, and 77 above.
betodealmeida
force-pushed
the
remove_old_deps
branch
2 times, most recently
from
2cab9e6 to
e96b419
Compare
betodealmeida
force-pushed
the
remove_old_deps
branch
from
400052c to
de1f98d
Compare
eschutho
approved these changes
Jul 21, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* chore: remove unneeded deps * fix lint * Run compile
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* chore: remove unneeded deps * fix lint * Run compile
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* chore: remove unneeded deps * fix lint * Run compile
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove
contextlib2andpathlib2, since they are backports that we no longer need.I also cleaned up the deps in
setup.py, we had duplicate deps.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
N/A
ADDITIONAL INFORMATION