-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons for tabs #15551
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15551 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 976 976
Lines 51320 51322 +2
Branches 6912 6912
=======================================
+ Hits 39485 39487 +2
Misses 11616 11616
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.185.27.244:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. However, I would love if we could solve the issue with the base icon color at the Icons component level.
@@ -119,6 +119,9 @@ const StyledEditableTabs = styled(StyledTabs)` | |||
`} | |||
`; | |||
|
|||
const StyledCancelXIcon = styled(Icons.CancelX)` | |||
color: ${({ theme }) => theme.colors.grayscale.base}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in another PR. Here we should define whether the standard is to use the iconColor
prop or go with this approach. Additionally, we might want to use this color as the base for the Icons component in general, to avoid repetition.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This pr migrates old icon to icons for tab cancelx icon.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
Go to sql editor and check the tabbed cancel x icon
ADDITIONAL INFORMATION