feat: custom error SQL Lab timeout #15342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add new custom error messaging when a query times out in SQL Lab.
Timeout exceptions were not bubbling up correctly in SQL Lab, so I fixed the code to make sure they bubble from
execute_sql_statement
toexecute_sql_statements
toget_sql_results
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
I added to my
superset_config.py
the following config:Then ran the following query under Postgres:
ADDITIONAL INFORMATION