Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing api tests for database connections #15124

Merged
merged 3 commits into from
Jun 11, 2021
Merged

fix: fixing api tests for database connections #15124

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e9f004
fixing api tests
AAfghahi Jun 11, 2021
33f5578
added test for no config method on create
AAfghahi Jun 11, 2021
0d482c5
added config method to validation tests
AAfghahi Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added config method to validation tests
  • Loading branch information
@AAfghahi
AAfghahi committed Jun 11, 2021
commit 0d482c54f89bfd9625ecb689446135a4b700c081
8 changes: 7 additions & 1 deletion tests/databases/api_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,7 +1675,12 @@ def test_validate_parameters_invalid_payload_schema(self):
"error_type": "INVALID_PAYLOAD_SCHEMA_ERROR",
"level": "error",
"extra": {
"messages": {"engine": ["Missing data for required field."],},
"messages": {
"configuration_method": [
"Missing data for required field."
],
"engine": ["Missing data for required field."],
},
"issue_codes": [
{
"code": 1020,
Expand All @@ -1691,6 +1696,7 @@ def test_validate_parameters_missing_fields(self):
self.login(username="admin")
url = "api/v1/database/validate_parameters"
payload = {
"configuration_method": ConfigurationMethod.SQLALCHEMY_FORM,
"engine": "postgresql",
"parameters": defaultdict(dict),
}
Expand Down