-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-filters): sort selected values on blur #14842
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14842 +/- ##
=======================================
Coverage 77.54% 77.54%
=======================================
Files 963 963
Lines 49248 49262 +14
Branches 6197 6199 +2
=======================================
+ Hits 38187 38199 +12
- Misses 10860 10862 +2
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
this is awesome, @villebro
Screen.Recording.2021-05-26.at.10.25.20.AM.mov |
bbce552
to
6beaecf
Compare
Thanks for splitting the PRs! @simcha90 @zhaoyongjie please help review, should be good to go! 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for this improvement.
* feat(native-filters): sort selected values on blur * remove new icons
* feat(native-filters): sort selected values on blur * remove new icons
* feat(native-filters): sort selected values on blur * remove new icons
SUMMARY
This is a follow up to #14486 and implements @mistercrunch 's suggestion to reorder selected values (#14486 (comment)). Previously, selected values were left in their original place in the native select filter. This change emulates that of the GitHub tag component, which places the selected values on top after the new values are persisted.
The plan is to add this functionality to the main Select component used throughout Superset in the future (probably as a prop that defaults to being disabled). However, to avoid causing potential functional or visual regressions in the application, this functionality will be kept only within the native filter component for now until it has been found to be fully stable.
BEFORE
Previously, the selected values stayed in their original positions after the dropdown was collapsed:
https://user-images.githubusercontent.com/33317356/119669257-97450780-be40-11eb-909c-34f81518354e.mp4
AFTER
Now the values are reordered when the dropdown is not visible:
https://user-images.githubusercontent.com/33317356/119669275-9b712500-be40-11eb-86e8-0ff621da784d.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION