Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db-connection-ui): Big Query Add Database Form #14829

Merged
merged 28 commits into from
Jun 5, 2021
Merged

feat(db-connection-ui): Big Query Add Database Form #14829

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c61e90a
fix(native-filters): Manage default value of filters by superset (#14…
simcha90 May 25, 2021
e0127ca
fix(native-filters): loop bug by simplify state handling (#14788)
villebro May 25, 2021
20d9eff
fix: set table name width to not hide icons when name is too long (#1…
einatbar May 25, 2021
3408eac
feat(explore): Remove default for time range filter and Metrics (#14661)
kgabryje May 25, 2021
c19e315
feat: chart gallery search improvement (#14484)
einatbar May 25, 2021
266cd27
Update schemas.py
hughhhh May 25, 2021
37e46c0
Update bigquery.py
hughhhh May 25, 2021
a837fa2
Fix tests
betodealmeida May 25, 2021
910065c
big query form is appearing on the screen
hughhhh May 25, 2021
1d43f1a
add name to allow for actions to get picked up
hughhhh May 25, 2021
3da3955
working post for saving db via paste
hughhhh May 25, 2021
abe5d0b
working file upload
hughhhh May 25, 2021
9c426f1
switch to textare
hughhhh May 26, 2021
441f341
better styles
hughhhh May 26, 2021
9174186
add delete buttong
hughhhh May 27, 2021
8ab9c9d
save formating
hughhhh May 27, 2021
6617600
wrap encrypted_extra
hughhhh May 27, 2021
15f9c65
formatting component
hughhhh May 27, 2021
856261f
clear out file input before reloading
hughhhh May 27, 2021
a547d6d
fix merge conflicts
hughhhh May 27, 2021
c80ff3d
remove default driver
hughhhh May 28, 2021
4a92dd6
address comments
hughhhh May 28, 2021
9f9285a
fixed merge conflicts
hughhhh Jun 4, 2021
3beba99
fix things off rebase
hughhhh Jun 4, 2021
ef5ea43
small refactore
hughhhh Jun 4, 2021
ed9b90a
more patches
hughhhh Jun 4, 2021
2e78a75
checkout space file
hughhhh Jun 4, 2021
7787200
fix variable ref
hughhhh Jun 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clear out file input before reloading
  • Loading branch information
@hughhhh
hughhhh committed May 27, 2021
commit 856261f00be99f44a1cdd1429ce5b6a85de65584
7 changes: 2 additions & 5 deletions superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,13 @@ const credentialsInfo = ({
onChange={async event => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but this event function is a little long. I'd suggest putting it into a separate function.

const file = event?.target?.files[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to put a type to your event, I'm pretty sure typescript will let you put event.target without the optional chaining. You should always get an event with a target on an input.

setFileToUpload(file.name);
const credentials = JSON.parse(await file.text());
const encrypted_extra = JSON.stringify({
credentials_info: credentials,
});
changeMethods.onParametersUploadFileChange({
target: {
name: 'encrypted_extra',
value: encrypted_extra,
value: await file.text(),
},
});
document.getElementById('selectedFile').value = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref here would be better

}}
/>
</div>
Expand Down