-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for filters in sqlLab #14765
feat: add support for filters in sqlLab #14765
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14765 +/- ##
==========================================
- Coverage 77.52% 77.37% -0.15%
==========================================
Files 960 963 +3
Lines 48819 49336 +517
Branches 6120 6230 +110
==========================================
+ Hits 37847 38176 +329
- Misses 10769 10961 +192
+ Partials 203 199 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5631687
to
e96e9e0
Compare
e96e9e0
to
f1e757a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just needs to fix the underscore dangle lint error
SQL lab can execute queries containing jinja templates.
You can specify key/values that your jinja template can use. However it's not possible to add additional filters like the Explore or the Dashboard would do.
This pull request adds support for filters provided in the sql lab parameters
This is very convenient to test templates since it behaves like the Explore or Dashboard.
Maybe the implementation details are not 100%. But I'm hoping the concept and ability to do this in sql lab is welcomed.