-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean remaining old directed force graph code #13431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13431 +/- ##
==========================================
- Coverage 76.05% 71.59% -4.46%
==========================================
Files 903 802 -101
Lines 45632 40595 -5037
Branches 5494 4147 -1347
==========================================
- Hits 34704 29065 -5639
- Misses 10766 11530 +764
+ Partials 162 0 -162
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
connection error in test |
Restarted the test, let's see if it was just flaky |
SUMMARY
This cleans up remaining code used for directed force chart which was recently migrated to Echart's graph chart in this PR
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
1.Remove all graphs from slices table and run
superset load_examples
andsuperset init
.It should load slices of viz_type graph_chart and not directed_force.
2.Run existing tests.
ADDITIONAL INFORMATION