Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connector for CrateDB #13152

Merged
merged 7 commits into from
Mar 11, 2021
Merged

feat: add connector for CrateDB #13152

merged 7 commits into from
Mar 11, 2021

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Feb 16, 2021

SUMMARY

Add support for CrateDB: https://crate.io/

TEST PLAN

Manual testing + new tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Feb 16, 2021

Codecov Report

Merging #13152 (6cad236) into master (2ce7982) will increase coverage by 18.27%.
The diff coverage is 29.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13152       +/-   ##
===========================================
+ Coverage   53.06%   71.33%   +18.27%     
===========================================
  Files         489      824      +335     
  Lines       17314    41123    +23809     
  Branches     4482     4260      -222     
===========================================
+ Hits         9187    29335    +20148     
- Misses       8127    11788     +3661     
Flag Coverage Δ
cypress 57.19% <29.71%> (+4.13%) ⬆️
hive 80.14% <ø> (?)
postgres 80.50% <ø> (?)
python 80.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/SqlLab/components/EstimateQueryCostButton.jsx 20.83% <ø> (ø)
...end/src/SqlLab/components/ExploreResultsButton.jsx 8.00% <ø> (ø)
...et-frontend/src/SqlLab/components/QueryHistory.jsx 50.00% <0.00%> (ø)
...end/src/SqlLab/components/RunQueryActionButton.tsx 52.77% <ø> (ø)
...erset-frontend/src/SqlLab/components/SouthPane.jsx 64.10% <ø> (ø)
...et-frontend/src/SqlLab/components/TableElement.jsx 5.88% <0.00%> (+0.20%) ⬆️
...end/src/SqlLab/components/TemplateParamsEditor.jsx 23.80% <ø> (ø)
...et-frontend/src/SqlLab/reducers/getInitialState.js 50.00% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 17.47% <0.00%> (-0.15%) ⬇️
...src/SqlLab/utils/reduxStateToLocalStorageHelper.js 61.53% <ø> (ø)
... and 657 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd443d...22138b2. Read the comment docs.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 18, 2021
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one more engine!

@villebro villebro merged commit bebac59 into apache:master Mar 11, 2021
@villebro villebro deleted the feat-crate branch March 11, 2021 21:03
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* feat: add connector for CrateDB

* added crate

* fix PyPI reference

* add tests

* added more clarity on installing crate

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants