-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-filters): Time native filter #12992
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a29c6d0
Add Time Filter component
agatapst 1c3f891
Improve Time Filter component
agatapst a7af2e9
Fix import errors
agatapst 4ed0cb5
Display Time Filter
agatapst 82a0320
Remove console logs
agatapst a727bfe
Change Control Panel
agatapst c2ba1c7
Remove unnecessary files
agatapst ff28359
Use time range override
agatapst 158d86b
test: fix tests
simcha90 5260fca
feat: re run pipeline
simcha90 56c5fc4
fix: fix some case for Time filter
simcha90 20308cb
Merge branch 'master' of github.com:apache/superset into time-cont
simcha90 a0619c0
fix: merge with master
simcha90 e3de8a6
Merge branch 'master' into time-cont
villebro 111b2d0
use original time range
villebro c52617c
fix height
villebro 639dac2
Merge branch 'master' into time-cont
villebro a67b0fe
add cross filter behavior
villebro 0659f3f
apply filters on initialization
villebro 7063b2e
Merge branch 'master' into time-cont
villebro 23592ea
add applied filter to overrides
villebro a71d35b
add unit tests for merge_extra_form_data
villebro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix height
- Loading branch information
commit c52617c66b371327e2744e4a4c5e6d1f4efc0d2d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core'; | ||
import { Behavior, ChartMetadata, ChartPlugin, t } from '@superset-ui/core'; | ||
import controlPanel from './controlPanel'; | ||
import transformProps from './transformProps'; | ||
import thumbnail from './images/thumbnail.png'; | ||
|
@@ -26,7 +26,7 @@ export default class TimeFilterPlugin extends ChartPlugin { | |
const metadata = new ChartMetadata({ | ||
name: t('Time range filter plugin'), | ||
description: 'Custom time filter plugin', | ||
isNativeFilter: true, | ||
behaviors: [Behavior.NATIVE_FILTER], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it can be also |
||
thumbnail, | ||
}); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit:
could we set a default name for
DateFilterControl
?