refactor(explore): move MetricControl and FilterControl to sub-component #12446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12446 +/- ##
==========================================
- Coverage 65.97% 63.10% -2.87%
==========================================
Files 1015 485 -530
Lines 49548 29944 -19604
Branches 5080 0 -5080
==========================================
- Hits 32687 18897 -13790
+ Misses 16714 11047 -5667
+ Partials 147 0 -147
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
hold!
ktmud
approved these changes
Jan 13, 2021
villebro
approved these changes
Jan 14, 2021
superset-frontend/spec/javascripts/explore/components/AdhocFilterOption_spec.jsx
Outdated
Show resolved
Hide resolved
...et-frontend/spec/javascripts/explore/components/AdhocFilterEditPopoverSqlTabContent_spec.jsx
Outdated
Show resolved
Hide resolved
superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx
Outdated
Show resolved
Hide resolved
…terEditPopoverSqlTabContent_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
…terOption_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
…ricEditPopoverTitle_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Ville, Thanks for the point out. |
villebro
added a commit
that referenced
this pull request
Jan 25, 2021
…ent (#12446) * wip * wip * wip * wip * move spec * wip * wip * remove unused file * wip * wip * Update superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopoverSqlTabContent_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * Update superset-frontend/spec/javascripts/explore/components/AdhocFilterOption_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * Update superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
mistercrunch
added
🍒 1.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
To make the explore code more maintainable, I will refactor some controls, so first I need to move some files to the sub-component.
TEST PLAN
IT / cypress run ok
ADDITIONAL INFORMATION