refactor : Change menu name and reorder items

[maloun96]

SUMMARY

https://trello.com/c/gDvXud8G/43-explorechange-menu-label-and-order
change label "Explore Chart" to "View Chart in Explore"
Reorder items

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TEST PLAN

1. Log in
2. Go to any Dashboard with charts
3. Click "..." on the chart

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[maloun96]

@junlincc @rusackas

[codecov-io]

Codecov Report

Merging #11993 (df26511) into master (7e6f04f) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #11993      +/-   ##
==========================================
- Coverage   63.75%   63.57%   -0.18%     
==========================================
  Files         941      940       -1     
  Lines       45654    45575      -79     
  Branches     4389     4373      -16     
==========================================
- Hits        29106    28976     -130     
- Misses      16371    16423      +52     
+ Partials      177      176       -1     

Flag	Coverage Δ
javascript	62.73% <0.00%> (-0.17%)	⬇️
python	64.07% <ø> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/src/dashboard/components/SliceHeaderControls.jsx	12.32% <0.00%> (ø)
superset/examples/energy.py	27.50% <0.00%> (-72.50%)	⬇️
superset-frontend/src/explore/exploreUtils.js	55.47% <0.00%> (-15.33%)	⬇️
...erset-frontend/src/SqlLab/components/ResultSet.tsx	66.82% <0.00%> (-9.48%)	⬇️
superset/db_engine_specs/sqlite.py	65.62% <0.00%> (-9.38%)	⬇️
...perset-frontend/src/messageToasts/actions/index.ts	80.76% <0.00%> (-7.70%)	⬇️
...nd/src/explore/components/controls/TextControl.tsx	42.85% <0.00%> (-5.53%)	⬇️
.../src/explore/components/AdhocMetricEditPopover.jsx	54.76% <0.00%> (-4.98%)	⬇️
...nd/src/dashboard/components/FiltersBadge/index.tsx	90.47% <0.00%> (-4.77%)	⬇️
superset/reports/commands/execute.py	92.50% <0.00%> (-3.80%)	⬇️
... and 47 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6f04f...df26511. Read the comment docs.

[junlincc]

some typos...please check ticket in trello again🙏 @maloun96

View Chart in Explore
Share Chart
Maximize Chart
Download as Image
Export CSV

[zuzana-vej]

I like the new order, thanks @junlincc. cc: @graceguo-supercat @ktmud

[maloun96]

@junlincc check it now!

[ktmud]

Are we using Trello for task management now? Because the link is a private board.

[rusackas]

Are we using Trello for task management now? Because the link is a private board.

That's just being used internally, to mirror Github issues and add color to them, or to track/prioritize little odds and ends that are not on Github. That link isn't really relevant in this context. @maloun96 you might want to just remove it ;)

[ktmud]

It seems the AFTER screenshot is not accurate. But I like the changes in the code.

Can we also have consistent casing for "Share chart" (vs "Share Chart")?

[junlincc]

@maloun96 Thanks for fixing the typo.
NEW AFTER

However, the instruction in Trello is below - capitalizing each word
View Chart in Explore
Share Chart
Maximize Chart
Download as Image
Export CSV

I scanned through most of the menuitem in Superset and the casing is a MESS across the product...
is there a standard for capitalizing (or not capitalizing) each word in the menuitem? if not, we SHOULD have one @mihir174

[rusackas]

Merging, as this fixes the acute issue. I'll open a new PR that capitalizes a few things, and we can expand on various capitalization cleanup items in there, with the input of @mirhir174