Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong key used FEATURE_FLAGS[LISTVIEW_DEFAULT_CARD_VIEW] #11824

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

amitmiran137
Copy link
Member

@amitmiran137 amitmiran137 commented Nov 26, 2020

SUMMARY

key name was incorrect rename from LISTVIEW_DEFAULT_CARD_VIEW--LISTVIEWS_DEFAULT_CARD_VIEW

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #11824 (9133a64) into master (13c51d5) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11824      +/-   ##
==========================================
- Coverage   63.59%   63.50%   -0.09%     
==========================================
  Files         916      459     -457     
  Lines       44479    28159   -16320     
  Branches     4227        0    -4227     
==========================================
- Hits        28286    17883   -10403     
+ Misses      16014    10276    -5738     
+ Partials      179        0     -179     
Flag Coverage Δ
javascript ?
python 63.50% <0.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 90.07% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.08% <0.00%> (-29.97%) ⬇️
superset/db_engine_specs/presto.py 69.76% <0.00%> (-12.53%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/db_engine_specs/postgres.py 97.56% <0.00%> (-2.44%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.14% <0.00%> (-0.81%) ⬇️
superset/reports/notifications/base.py 95.00% <0.00%> (-0.46%) ⬇️
... and 476 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c51d5...9133a64. Read the comment docs.

@amitmiran137 amitmiran137 changed the title fix: FEATURE_FLAGS[LISTVIEW_DEFAULT_CARD_VIEW] wrong keyword used by… fix: FEATURE_FLAGS[LISTVIEW_DEFAULT_CARD_VIEW] wrong key used Nov 26, 2020
@amitmiran137 amitmiran137 changed the title fix: FEATURE_FLAGS[LISTVIEW_DEFAULT_CARD_VIEW] wrong key used fix: wrong key used FEATURE_FLAGS[LISTVIEW_DEFAULT_CARD_VIEW] Nov 26, 2020
@etr2460 etr2460 merged commit ec01691 into apache:master Nov 30, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants