-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Dashboard-Native Filters #11814
Merged
Merged
Changes from 1 commit
Commits
Show all changes
191 commits
Select commit
Hold shift + click to select a range
aa427c0
wip: filter create modal
suddjian 12d2d4e
add a feature flag
suddjian a5e33ae
automatic changes to package lock
suddjian 82b83d8
wip
suddjian 78bf0e9
filter sidebar and basic state management
suddjian 7624042
move create button to the sidebar
suddjian 8026e42
Merge branch 'master' into dashboard-native-filters
suddjian c1afcb6
first step for edit filterconfig
pkdotson 056d4d3
partially fix tests...
suddjian b1b40ea
edits to types and comments
suddjian 7388ced
respect feature flag on the filter sidebar
suddjian eddd87e
add filterconfig form
pkdotson 869f36e
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
pkdotson 40801fc
get input state working
pkdotson 3a2da31
feat: tree filter scopes UI
simcha90 44c3e0c
fix: turn on flag
a06b3cb
sticky filter bar
suddjian a4117f3
stop preferring default export
suddjian d602700
feat: finish filter scoping
simcha90 cac8416
Merge branch 'scopes' of github.com:simchaNielsen/incubator-superset …
simcha90 dce5f46
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
simcha90 21d2b28
fix: under toggle
simcha90 8422d54
Merge branch 'master' into dashboard-native-filters
villebro 0949085
fix: title
simcha90 344cd94
fix: add licence
simcha90 ae33570
refactor: update TS
simcha90 3f5ea72
fix: fix on reopen modal + validation
simcha90 d5d75f6
new filter bar menu
rusackas cbb2c65
adding, but commenting out, bulk scoping action
rusackas b62e06d
adding some placeholder buttons and styles therefor
rusackas b1302d3
feat: add filter chart
villebro 26a7b40
add relative path to package.json
villebro 66dd647
update modal
pkdotson 0445f3e
update branch
pkdotson 3f9a0f9
Merge branch 'dashboard-native-filters' into scopes
suddjian 05193e7
Merge pull request #44 from simchaNielsen/scopes
suddjian e9a5204
a little input styling... just getting warmed up
rusackas 5fc2346
Revert "feat: add filter chart"
suddjian faea463
Revert "add relative path to package.json"
suddjian 5c96faa
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
suddjian 845e79a
https package lock idk
suddjian 3b5f5a6
feat: add filter chart
villebro d53feb0
add relative path to package.json
villebro 4a509a2
flexboxes all the way down
rusackas 941d1d0
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
rusackas 28d562f
dynamically generate groupby and datasource in select control
villebro 0774764
big wip
suddjian 882668f
fix target column name
villebro c331e23
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
suddjian 93f0dcd
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
suddjian 091f8b2
no importing nonexistent things
suddjian 35e8702
styles and name editing
suddjian 8c1a7f3
Add hook for retrieval of all filter states
villebro a044f4b
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
villebro aa0b847
start with a new filter when clicking add filter
suddjian b445023
handle removed filters gracefully
suddjian fe736f2
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
suddjian 03b0b5c
fix incorrect default filter configuration
villebro 84c1504
add fields to useAllFilterState
villebro 392924b
add redux for filterconfigs
pkdotson 24195bf
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
pkdotson c40ac69
add support for native_filters
villebro a4506c3
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
villebro bc243a7
remove consoles
pkdotson 2b744e7
improve filter removal
suddjian 53bd174
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
suddjian 4cc44e6
unbreak infinite loop
villebro 5363697
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
villebro 3fa6f05
basic sidebar toggling working!
rusackas d7d98d6
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
rusackas ec2c2db
collapsing and menu working more smoothly
rusackas e8a142b
linting
rusackas f7fc973
make dataset and column inputs work
suddjian 869b409
save filter values properly
suddjian 9d9d5c8
add dashboard event for filter updates
villebro 8682b84
guarded
suddjian c0ba458
Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…
villebro f91f5af
apply filters properly
villebro 3b6dedb
fix schema
villebro bb20872
making New Filter button a link
rusackas 83cf69d
gridunits ftw
rusackas aa44002
centering modal
rusackas 7507b15
tis not a button anymore! nixing type.
rusackas ecb8780
plus and collapse buttons instead of "more" menu
rusackas deae5b9
updating full size filter icons
rusackas bb3e435
adding icons to filter collapsing/expanding
rusackas da1c779
turning off animation, but leaving class-based animation css
rusackas 9957c92
Merge branch 'master' into dashboard-native-filters
villebro fb4ff44
fix linting error
villebro 9ba1e32
fix native filters for legacy charts
villebro b147aaf
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
rusackas ea8600f
updates test
pkdotson 1315f46
no individual apply buttons
suddjian fb356fa
fix bugs with filter config modal
suddjian a029be5
remove redundant code
villebro 0c0e04c
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
pkdotson bf471c8
switch to the filter with validation errors on submit
suddjian 6e7a4a6
separate form validation
suddjian c921ee9
switch config button from add to edit
suddjian 2cd0af9
Merge branch 'master' into dashboard-native-filters
suddjian de76686
update tests
pkdotson f66e575
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
pkdotson badf227
oops forgot to add the fancy new useChangeEffect hook
suddjian c9e8e72
comments and code reorganization
suddjian 7cd48b8
rename native_filters to extr_form_data and move hook
villebro af29eec
Merge branch 'master' into dashboard-native-filters
villebro 5b3b2f7
disable native filters in viz selector
villebro 759516d
add cascading
villebro e8ccf4f
implement new extra form data api
villebro a94d733
cleanup
villebro 2c624f9
updates tests
pkdotson bfa0644
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
pkdotson 1d5191f
bump npm packages
villebro 1b4cf7b
Merge branch 'master' into dashboard-native-filters
villebro 6652a69
fix bad merge on package.json + lock
villebro 6488877
lint
villebro a6b4f69
replace in and not in with uppercase
villebro 1ba6e3f
lint
villebro 3b95a61
lint
villebro 830cb18
lint
villebro bca3b58
lint
villebro 7c64b0f
bulk test fix
pkdotson c529840
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
pkdotson 40fe216
Sort select input alphabetically
agatapst d52a419
Change type for sorting elements
agatapst 6592543
Merge pull request #51 from agatapst/native-filters/sort-select-input
villebro 81b81d6
fix rest of unit tests
pkdotson 01f5b7c
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
pkdotson 2c7e5a2
make filter operators all uppercase
villebro 4b831bd
Merge branch 'master' into dashboard-native-filters
villebro 9f004e8
Hide Filter bar when there are no filters
agatapst e0c1a77
Show edit button for dashboard owners only
agatapst f0f1888
Add visible argument to filters toggle function to avoid future regre…
agatapst a143c4f
Improve Toggle filters bar function
agatapst 102d956
Merge pull request #52 from agatapst/native-filters/filter-bar-elements
villebro 71a0542
lint
villebro b50956d
fix js lint + set createNewOnOpen
villebro 0adfa03
Handle setting extra form data in Filter Bar instead of Filter Control
agatapst 4cc9a03
Add Handle apply filter function to Apply button
agatapst 3b9ab43
Allow applying changes instantly
agatapst edff7fd
Fix types
agatapst 00027db
remove console logs
suddjian d80738b
Merge branch 'master' into dashboard-native-filters
suddjian 661e377
Add Error Boundary component to Filter bar and Filter Config Modal
agatapst 61065ec
Merge pull request #54 from agatapst/native-filters/error-boundary
villebro 87a6f34
fix jest tests
villebro 1ebaf46
update native filters tests to pass
pkdotson 55b3d98
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
pkdotson b4b1506
Merge pull request #53 from agatapst/native-filters/apply-button
villebro f675fc2
reset cypress baseUrl
suddjian 1b9eb9b
Merge branch 'master' into dashboard-native-filters
suddjian 5c44d6f
remove unnecessary field
suddjian 72f8989
cleanup: remove unused state fields
suddjian 3319f95
move unrelated types to an appropriate location
suddjian 9233753
remove misplaced resource fetch error logic
suddjian 24a759d
fix cascadeParentIds error
suddjian e6e7bc6
fix cypress password
villebro 296675d
Merge branch 'master' into dashboard-native-filters
villebro 679e992
initial attempt at fixing scope issue
suddjian 18e9188
fix bad merge
villebro 0cbdb44
fix lint
villebro 4c0b34e
trying out makeApi for saving filters
suddjian 6af4dea
remove unused import
suddjian 7762b4f
fix test
suddjian 2e5423c
silence bad test
suddjian 0a75d7f
Merge branch 'master' into dashboard-native-filters
villebro c91e00a
add native-filter feat flag config
pkdotson 292c9c6
oops fix here
pkdotson a35d4a0
remove space
pkdotson d888de2
Merge branch 'master' into dashboard-native-filters
villebro 07c3044
Update superset-frontend/src/common/components/index.tsx
suddjian 633ba0a
Update superset-frontend/cypress-base/cypress/integration/dashboard/n…
suddjian 9331bfc
Merge branch 'master' into dashboard-native-filters
villebro 3a61724
use styledMount in tests
suddjian 0a7d7d3
comment
suddjian 08aa50e
Update superset-frontend/src/dashboard/components/nativeFilters/Filte…
suddjian 5d352e2
Update superset-frontend/src/dashboard/components/nativeFilters/Filte…
suddjian f9cfae2
Update superset-frontend/src/dashboard/components/nativeFilters/Filte…
suddjian b7ee19b
Update superset-frontend/src/dashboard/components/nativeFilters/Filte…
suddjian 15cce2c
address PR feedback
suddjian fa013d2
fix package lock
suddjian 57b7428
null guards
suddjian ff1875f
Merge branch 'master' into dashboard-native-filters
villebro 57450d1
Fix charts resizing
agatapst 52cbe90
Merge pull request #66 from agatapst/native-filters/fix-resizing
villebro 0f991f7
fix cypress tests
pkdotson 700dbfd
Merge branch 'dashboard-native-filters' of https://github.com/preset-…
pkdotson cf58305
Merge branch 'master' into dashboard-native-filters
pkdotson 522b7b6
Merge branch 'master' into dashboard-native-filters
pkdotson f91e9bc
add in nativefilters to form data
pkdotson 800951f
fix lint and test
pkdotson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix test
- Loading branch information
commit 7762b4f4ebfb906219bff32ade200be0393022a4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering going through and doing the
import { styledMount as mount } from 'spec/helpers/theming';
thing everywhere we're usingThemeProvider
in awrappingComponent
. Wonder if that would work here, and still usewrappingComponent
for just the<Provider>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only we can just start migrating these to React Testing Library, then you can use
import { render } from 'spec/helpers/testing-library'
🎉Disclaimer: I added this utils but didn't test whether it actually works.