feat: report/alert list CRUD view #11802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilykuang
force-pushed
the
lily/alert-list-view
branch
from
aa16e16 to
549f736
Compare
lilykuang
commented
Nov 24, 2020
| }, | ||
| { | ||
| Header: t('Schedule'), | ||
| accessor: 'crontab', |
There was a problem hiding this comment.
This column will be updated later and keeping it as plain text column for now
lilykuang
force-pushed
the
lily/alert-list-view
branch
4 times, most recently
from
b4c85ed to
429cf67
Compare
Codecov Report
@@ Coverage Diff @@
## master #11802 +/- ##
==========================================
- Coverage 67.61% 60.76% -6.85%
==========================================
Files 924 880 -44
Lines 44833 43135 -1698
Branches 4251 3785 -466
==========================================
- Hits 30313 26213 -4100
- Misses 14417 16922 +2505
+ Partials 103 0 -103
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lilykuang
force-pushed
the
lily/alert-list-view
branch
2 times, most recently
from
0e07dcb to
ead0c44
Compare
lilykuang
force-pushed
the
lily/alert-list-view
branch
2 times, most recently
from
4beb1b3 to
87d21aa
Compare
villebro
approved these changes
Nov 28, 2020
Comment on lines
48
to
51
| color: ${({ status, theme }) => { | ||
| if (status === 'alerting') return '#FBC700'; | ||
| if (status === 'failed') return theme.colors.error.base; | ||
| if (status === 'ok') return theme.colors.success.base; |
There was a problem hiding this comment.
Could we use enum for status here, potentially with a switch?
nytai
reviewed
Nov 30, 2020
| @@ -40,6 +41,7 @@ export function useListViewResource<D extends object = any>( | |||
| handleErrorMsg: (errorMsg: string) => void, | |||
| infoEnable = true, | |||
| defaultCollectionValue: D[] = [], | |||
| baseFilters: FilterValue[] = [], // must memolize otherwise infinite loop | |||
There was a problem hiding this comment.
Suggested change
| baseFilters: FilterValue[] = [], // must memolize otherwise infinite loop | |
| baseFilters: FilterValue[] = [], // must be memoized |
nytai
reviewed
Nov 30, 2020
superset/app.py
Outdated
Comment on lines
424
to
429
| if feature_flag_manager.is_feature_enabled("SIP_34_QUERY_SEARCH_UI"): | ||
| appbuilder.add_view_no_menu(AlertReportModelView) |
There was a problem hiding this comment.
Is this the correct feature flag?
lilykuang
force-pushed
the
lily/alert-list-view
branch
from
87d21aa to
c2908ef
Compare
riahk
approved these changes
Nov 30, 2020
nytai
approved these changes
Dec 1, 2020
lilykuang
force-pushed
the
lily/alert-list-view
branch
from
99ae01d to
fca0fb6
Compare
lilykuang
force-pushed
the
lily/alert-list-view
branch
from
f9c3349 to
009f0ea
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
/api/v1/reporttypeSwitchand it to storybookSIP_34_ALERTS_UIBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION