Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker healthcheck. #11747

Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix: docker healthcheck. #11747

merged 1 commit into from
Nov 23, 2020

Conversation

PMExtra
Copy link
Contributor

@PMExtra PMExtra commented Nov 19, 2020

SUMMARY
Fix docker healthcheck.

Default env SUPERSET_PORT is 8080 but health check is check for 8088.
It should follow the environment in health check.

@willbarrett willbarrett changed the title Fix docker healthcheck. fix: docker healthcheck. Nov 23, 2020
@willbarrett willbarrett merged commit a062cbb into apache:master Nov 23, 2020
@PMExtra
Copy link
Contributor Author

PMExtra commented Nov 24, 2020 •
edited
Loading

I'm so sorry! This may be a bug.
$$ is only works in docker-compose.yml and doesn't work in Dockerfile.

I will test it again and submit a fix later today. You might consider rolling back this commit.

@PMExtra PMExtra mentioned this pull request Nov 24, 2020
Merged
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PMExtra @willbarrett @mistercrunch