[SQL Lab] Adding indexes to table metadata #1160
Conversation
| @@ -102,22 +102,27 @@ class SqlEditorTopToolbar extends React.Component { | |||
| const tableName = tableOpt.value; | |||
| const qe = this.props.queryEditor; | |||
| const url = `/caravel/table/${qe.dbId}/${tableName}/${qe.schema}/`; | |||
|
|
|||
| this.setState({ tableLoading: true }); | |||
There was a problem hiding this comment.
I could not find the usage of the tableLoading
There was a problem hiding this comment.
it get's set to false after the async request comes back https://github.com/airbnb/caravel/pull/1160/files#diff-2b41d6ca02b4b8163346107f847ee958R118
There was a problem hiding this comment.
yep, I could find the place in code where tableLoading is read from the state.
There was a problem hiding this comment.
ah you are right, sorry i missed that too. good catch!
@mistercrunch do you have a loading state you are adding to use with this.state.tableLoading?
There was a problem hiding this comment.
state.tableLoading is used at line 164. It's the Select's inline loading spinner. I used it only for when the content was loading before, now I also use it while the table metadata is loading.
|
LGTM after the comment is resolved. |
|
lgtm |
mistercrunch
added
🏷️ bot
Showing the json isn't the most polished option, but the keys that SqlAlchemy return aren't 100% homogenous and thought this would do the trick of exposing everything we have with minimal effort.
Based on the PyHive documentation, this will show the partition key for Hive/Presto tables