style: make <Label/> not uppercase #11355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rolling back the change I made that forced all
<Label/>
to beuppercase
. In many cases, labels contain table names, viz type names, filter summary and other things where case matters. We should leave as is by default.The original intent was to have good vertical alignment of letters inside the label, and having all letters have the same height make things look more even, but I think that doesn't matter much.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
before
TEST PLAN
CSS change, so a simple visual review of the application