Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: make <Label/> not uppercase #11355

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

mistercrunch
Copy link
Member

SUMMARY

Rolling back the change I made that forced all <Label/> to be uppercase. In many cases, labels contain table names, viz type names, filter summary and other things where case matters. We should leave as is by default.

The original intent was to have good vertical alignment of letters inside the label, and having all letters have the same height make things look more even, but I think that doesn't matter much.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen Shot 2020-10-20 at 10 55 44 PM

before

Screen Shot 2020-10-20 at 10 56 16 PM

TEST PLAN

CSS change, so a simple visual review of the application

@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #11355 into master will decrease coverage by 4.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11355      +/-   ##
==========================================
- Coverage   65.76%   60.93%   -4.83%     
==========================================
  Files         838      394     -444     
  Lines       39841    24951   -14890     
  Branches     3655        0    -3655     
==========================================
- Hits        26201    15205   -10996     
+ Misses      13539     9746    -3793     
+ Partials      101        0     -101     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 60.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/dashboard/components/dnd/handleHover.js
superset-frontend/src/components/ListView/index.ts
...frontend/src/dashboard/actions/dashboardFilters.js
...et-frontend/src/dashboard/containers/Dashboard.jsx
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx
...frontend/src/dashboard/util/dropOverflowsParent.js
.../src/dashboard/components/UndoRedoKeylisteners.jsx
superset-frontend/src/CRUD/utils.js
...c/dashboard/components/gridComponents/Markdown.jsx
...t-frontend/src/dashboard/components/SliceAdder.jsx
... and 435 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43aca6a...7fde99b. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this as the default, especially in places where case matters, especially metric aliases etc.

@mistercrunch
Copy link
Member Author

We could re-introduce uppercase in specific places where it makes sense, but unclear where that'd be. Maybe in query status in the query history for instance, but unclear whether it's even worth it.

@mistercrunch mistercrunch merged commit 6dd5d5c into apache:master Oct 22, 2020
@mistercrunch mistercrunch deleted the label_lower branch October 22, 2020 00:29
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants