Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(sqllab): wrap text in monospace db-provided error messages #11354

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Oct 21, 2020

SUMMARY

closes #11352

It seems that Superset errors do not wrap (the example is from SQL Lab and thus I'm uncertain how broad of an issue this is) meaning one needs to scroll horizontally in order to parse the message.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen Shot 2020-10-20 at 9 57 04 PM

before

Screen Shot 2020-10-20 at 9 59 01 PM

TEST PLAN

visual / manual checks with different error messages and screen sizes

@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #11354 into master will decrease coverage by 4.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11354      +/-   ##
==========================================
- Coverage   65.76%   61.57%   -4.19%     
==========================================
  Files         838      838              
  Lines       39841    39838       -3     
  Branches     3655     3655              
==========================================
- Hits        26201    24531    -1670     
- Misses      13539    15126    +1587     
- Partials      101      181      +80     
Flag Coverage Δ
#cypress ?
#javascript 62.64% <ø> (ø)
#python 60.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx 76.11% <ø> (-4.48%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43aca6a...f8c8aed. Read the comment docs.

@mistercrunch mistercrunch merged commit 69046f0 into apache:master Oct 22, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages do not wrap
3 participants