Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn SQL templating off by default #11172

Merged
merged 7 commits into from
Oct 8, 2020
Merged

chore: turn SQL templating off by default #11172

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bc90c76
feat: possible to turn off SQL templating
dpgaspar Oct 6, 2020
fc07f5f
turn SQL templating off by default
dpgaspar Oct 6, 2020
4be94a3
Update UPDATING.md
dpgaspar Oct 6, 2020
ead993e
fix missing PR number
dpgaspar Oct 7, 2020
7736595
Merge remote-tracking branch 'origin/fix/disable-sql-templates' into …
dpgaspar Oct 7, 2020
0178361
fix missing PR number
dpgaspar Oct 7, 2020
2005044
Merge branch 'master' into fix/disable-sql-templates
dpgaspar Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ assists people when migrating to a new version.

## Next

* [11172](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default, to turn it by setting `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're in here, could you move the existing Next stuff to 0.37.2? Looks like that wasn't done yet.

Also, make sure you update the PR number

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, and the UPDATING is absolutely correct, there are no warning or breaking changes on 0.37.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, gotcha. i forgot that 0.37.2 was only cherrypicked PRs


* [10887](https://github.com/apache/incubator-superset/pull/10887): Breaking change: The custom cache backend changed in order to support the Flask-Caching factory method approach and thus must be registered as a custom type. See [here](https://flask-caching.readthedocs.io/en/latest/#custom-cache-backends) for specifics.

Expand Down