Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: more 'datasource' -> 'dataset' renaming #11055

Merged
merged 5 commits into from
Oct 6, 2020
Merged

chore: more 'datasource' -> 'dataset' renaming #11055

merged 5 commits into from
Oct 6, 2020

Conversation

mistercrunch
Copy link
Member

see title ^^^

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020 •
edited
Loading

Codecov Report

Merging #11055 into master will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11055   +/-   ##
=======================================
  Coverage   61.64%   61.64%           
=======================================
  Files         815      815           
  Lines       38496    38499    +3     
  Branches     3619     3621    +2     
=======================================
+ Hits        23729    23734    +5     
+ Misses      14581    14579    -2     
  Partials      186      186
Flag Coverage Δ
#javascript 62.05% <60.00%> (+<0.01%) ⬆️
#python 61.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/addSlice/AddSliceContainer.tsx 75.86% <ø> (ø)
...t-frontend/src/dashboard/components/SliceAdder.jsx 80.59% <ø> (ø)
...-frontend/src/datasource/ChangeDatasourceModal.tsx 74.54% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 69.58% <ø> (ø)
...perset-frontend/src/datasource/DatasourceModal.tsx 74.46% <0.00%> (ø)
...rontend/src/explore/components/PropertiesModal.tsx 54.92% <ø> (ø)
.../explore/components/controls/DatasourceControl.jsx 64.86% <ø> (ø)
...et-frontend/src/explore/controlPanels/sections.jsx 100.00% <ø> (ø)
...erset-frontend/src/profile/components/Security.tsx 100.00% <ø> (ø)
...uperset-frontend/src/utils/getClientErrorObject.ts 86.48% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d62f3...6cb8b7c. Read the comment docs.

@willbarrett
Copy link
Member

@mistercrunch looks like it needs a rebase then you'll be good to go.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 6, 2020
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 6, 2020
@mistercrunch mistercrunch merged commit 3d7b805 into apache:master Oct 6, 2020
@willbarrett willbarrett deleted the datasource_dataset branch October 6, 2020 14:54
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch @auxten
chore: more 'datasource' -> 'dataset' renaming (apache#11055)
8a2b103 
* chore: more 'datasource' -> 'dataset' renaming

* fix build

* explicitely setting disabled to false to avoid cypress confusion

* fix tests

* RAT
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @codecov-commenter @willbarrett