Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prefer allow/deny terminology #10320

Merged
merged 3 commits into from
Jul 15, 2020
Merged

chore: prefer allow/deny terminology #10320

merged 3 commits into from
Jul 15, 2020

Conversation

villebro
Copy link
Member

SUMMARY

This replaces terminology containing white/black with allow/deny correspondingly.

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

etr2460
etr2460 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

@villebro villebro merged commit ac85aeb into apache:master Jul 15, 2020
@villebro villebro deleted the villebro/allow-deny branch July 15, 2020 16:23
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@villebro @auxten
chore: prefer allow/deny terminology (apache#10320)
ca29221 
* chore: prefer allow/deny terminology

* fix tests

* add PR reference
@villebro villebro mentioned this pull request Sep 16, 2022
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villebro @etr2460 @mistercrunch