fix: row count container alignment

[etr2460]

SUMMARY

It looks like this change wasn't wasn't tested for both sides of this feature flag LIST_VIEWS_NEW_UI or the config ENABLE_REACT_CRUD_VIEWS (uncertain how these actually interact with each other)

hopefully we can reach feature parity soon so that we can all migrate to having it True, reducing the complexity of working around this

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

Ensure the row count container is aligned properly

Even after following the instructions from your PR (enabling the feature flag) @nytai, I wasn't able to get the new UI to show up. Could you direct me how to test that this works with the new styling?

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

to: @nytai @graceguo-supercat @ktmud

[ktmud]

[nytai]

@etr2460 The LIST_VIEWS_NEW_UI refers to some changes in the listview filters, it's unrelated to this change. Sorry for the confusing name, it should be USE_NEW_FILTER_UI or something similar. Both charts, dashboards, and datasets have the new UI under ENABLE_REACT_CRUD_VIEWS, which makes the tables full width, hence the absolute positioning on the row count. Looks like I missed checking the welcome page which is also using the ListView component.

The way to fix this is to either make the welcome page full-width or go back to the float: right styling that was in place before (which should mostly be the same)

[nytai]

let's just change this to

float: right;
margin-right: 20px;

which should be enough to make this look OK on both the /superset/welcome and the /tablemodelview/list/ pages with ENABLE_REACT_CRUD_VIEWS flag enabled. The LIST_VIEWS_NEW_UI flag is only related to the filters ui, you can update it to LIST_VIEWS_NEW_FILTER_UI to be more semantically correct if you're up for it.