Skip to content

DrillDetailTable's pageSize is 50, but the pageSizeOptions allows the default 5,15,25,50,100 #36267

@durban77

Description

@durban77

Bug description

On the Drill to details table of a chart, when you set the pageSize to lower than 50, you can overread the results by jumping to the last page. Also setting the pageSize to 100 only shows 50 rows.

The cause is that the pageSize is set to a constant value of 50, but the pageSizeOptions inherit a [5,15,25,50,100] valueset and the UI shows the pageSize as a user changeable value.

One possible solution is to set the pageSizeOptions to ['50'] because it is the only valid option right now. This will cause the pageSize selector to have only one value.
DrillDetailPane.tsx
defaultPageSize={PAGE_SIZE}
++ pageSizeOptions={['50']}

I'm happy to make the adjustment, but please someone approve this!

Screenshots/recordings

Image

Superset version

master / latest-dev

Python version

I don't know

Node version

I don't know

Browser

Not applicable

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood first issues for new contributors

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions