The LABEL_POSITION value is invalid.

[chkang-idk2]

Bug description

I think it should be changed....

/var/local/idk2/heartset/superset-frontend/plugins/plugin-chart-echarts/src/constants.ts
============from:
export const LABEL_POSITION: [LabelPositionEnum, string][] = [
[LabelPositionEnum.Top, 'Top'],
[LabelPositionEnum.Left, 'Left'],
[LabelPositionEnum.Right, 'Right'],
[LabelPositionEnum.Bottom, 'Bottom'],
[LabelPositionEnum.Inside, 'Inside'],
[LabelPositionEnum.InsideBottomLeft, 'Inside left'],
[LabelPositionEnum.InsideBottomRight, 'Inside right'],
[LabelPositionEnum.InsideTop, 'Inside top'],
[LabelPositionEnum.InsideBottom, 'Inside bottom'],
[LabelPositionEnum.InsideTopLeft, 'Inside top left'],
[LabelPositionEnum.InsideBottomLeft, 'Inside bottom left'],
[LabelPositionEnum.InsideTopRight, 'Inside top right'],
[LabelPositionEnum.InsideBottomRight, 'Inside bottom right'],
];

============to:
export const LABEL_POSITION: [LabelPositionEnum, string][] = [
[LabelPositionEnum.Top, 'Top'],
[LabelPositionEnum.Left, 'Left'],
[LabelPositionEnum.Right, 'Right'],
[LabelPositionEnum.Bottom, 'Bottom'],
[LabelPositionEnum.Inside, 'Inside'],
[LabelPositionEnum.InsideLeft, 'Inside left'],
[LabelPositionEnum.InsideRight, 'Inside right'],
[LabelPositionEnum.InsideTop, 'Inside top'],
[LabelPositionEnum.InsideBottom, 'Inside bottom'],
[LabelPositionEnum.InsideTopLeft, 'Inside top left'],
[LabelPositionEnum.InsideBottomLeft, 'Inside bottom left'],
[LabelPositionEnum.InsideTopRight, 'Inside top right'],
[LabelPositionEnum.InsideBottomRight, 'Inside bottom right'],
];

Screenshots/recordings

Superset version

3.1.3

Python version

3.11

Node version

16

Browser

Chrome

Additional context

No response

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[dosubot]

Hello @chkang-idk2! I'm here to help you with any bugs, questions, or contributions you have for Superset. Let me know how I can assist you!

To correct the LABEL_POSITION value and avoid displaying multiple "Inside right" options in the dropdown list, you should update the constants.ts file by removing the duplicate entries and ensuring each label position is unique.

Here is the corrected LABEL_POSITION array:

export const LABEL_POSITION: [LabelPositionEnum, string][] = [
  [LabelPositionEnum.Top, 'Top'],
  [LabelPositionEnum.Left, 'Left'],
  [LabelPositionEnum.Right, 'Right'],
  [LabelPositionEnum.Bottom, 'Bottom'],
  [LabelPositionEnum.Inside, 'Inside'],
  [LabelPositionEnum.InsideLeft, 'Inside left'],
  [LabelPositionEnum.InsideRight, 'Inside right'],
  [LabelPositionEnum.InsideTop, 'Inside top'],
  [LabelPositionEnum.InsideBottom, 'Inside bottom'],
  [LabelPositionEnum.InsideTopLeft, 'Inside top left'],
  [LabelPositionEnum.InsideBottomLeft, 'Inside bottom left'],
  [LabelPositionEnum.InsideTopRight, 'Inside top right'],
  [LabelPositionEnum.InsideBottomRight, 'Inside bottom right'],
];

This change removes the incorrect entries [LabelPositionEnum.InsideBottomLeft, 'Inside left'] and [LabelPositionEnum.InsideBottomRight, 'Inside right'] and replaces them with the correct entries [LabelPositionEnum.InsideLeft, 'Inside left'] and [LabelPositionEnum.InsideRight, 'Inside right'] ^[1].

To continue talking to Dosu, mention @dosu.

[hainenber]

@chkang-idk2 thanks for finding out this issue! I'll open a PR to fix this.