"SHOW LABEL" checkbox for an annotation does nothing

[sfirke]

In both 2.0.1 and 2.1.0rc1, nothing happens when I check the "SHOW LABEL" box. Whether or not it's checked, the label appears on the chart legend and does not show on the chart. I'm not sure what it's supposed to do, but it should do something.

This is the box:

[D3nn3]

Can confirm, also just experienced this bug. I didn't test this, but the GENERIC_CHART_AXES feature flag could have something to do with this. Afaik before enabling the feature flag we didn't have this problem on our production environment.

@sfirke : Do you guys have the feature flag enabled too or do you have this problem without having it enabled?

[sfirke]

Yes I have that feature flag enabled.

…

On Mon, Mar 13, 2023, 10:32 AM D3nn3 ***@***.***> wrote: Can confirm, also just experienced this bug. I didn't test this, but the GENERIC_CHART_AXES feature flag could have something to do with this. Afaik before enabling the feature flag we didn't have this problem on our production environment. @sfirke <https://github.com/sfirke> : Do you guys have the feature flag enabled too or do you have this problem without having it enabled? — Reply to this email directly, view it on GitHub <#23218 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZYDEGMROKDBWO5PJX2MILW34VWJANCNFSM6AAAAAAVJXS6BM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[rusackas]

This version of Superset is no longer supported. If anyone is still encountering this in current versions (3.x) please open a new Issue or a PR to address the problem.

[sfirke]

In Superset 3.0.1, I still experience the original behavior.

That said the only annotations I use are horizontal lines defined with "FORMULA". Looking at the PR that introduced this feature #17307, I see the examples are of events and intervals. I don't have experience with those, but maybe the functionality works as intended there? And "show label" doesn't apply to Formula annotations, since that label name always shows in the legend?

Since this isn't relevant to me right now I won't go farther and I'm okay with this being closed.

[D3nn3]

Is this maybe related to the following issue? #26206