Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Local/custom viz #1405

Closed
niconoe opened this issue Oct 21, 2016 · 6 comments
Closed

[Feature] Local/custom viz #1405

niconoe opened this issue Oct 21, 2016 · 6 comments

Comments

@niconoe
Copy link
Contributor

niconoe commented Oct 21, 2016

Hello,

For a current project, I'd like to have the feature of adding custom/local visualizations to Caravel. That issue has been discussed in #697, which is closed now.

I therefore plan to start exploring how I could make this improvement, but have a few questions:

  • Is it still something the team is interested in with a good chance of eventually merging my branch (if works properly)?
  • Do you know if someone else is already working on this?
  • Any strong opinions about what I should and shouldn't do?

Thanks a lot!

@cons0l3
Copy link

cons0l3 commented Oct 21, 2016

I would love to have a seamless and effordless way of putting new vizualisations in or take unused out. Every visualisation could be encapsulated as a module/class/... with a defined structure (interface) that can be extended. it would require a vizualisation-manager to find all currently installed viz and make them renderable for the slices and dashboard...

@niconoe
Copy link
Contributor Author

niconoe commented Oct 21, 2016

Thanks !

My idea is to make it work with "one directory per visualization". A first step would be to rework the existing stock viz like that, then in a second step to also load local stuff from a user directory. In that form, I don't think it would allow disabling existing viz like you suggest, but maybe we should go iteratively.

@niconoe niconoe changed the title Local/custom viz [Feature] Local/custom viz Oct 21, 2016
@cons0l3
Copy link

cons0l3 commented Oct 21, 2016

yes, splitting the viz into separate modules is the first step. abstracting the viz to conform to a common interface the second. a viz-manager or viz-factory can than be used through out the rest of caravel to get an instance of a named viz. a manager needs to know howto find a named viz and get a "instance" of it or delegate a call to it. definitely the last step in the journey...

@xrmx
Copy link
Contributor

xrmx commented Oct 21, 2016

FYI disabling visualizations is already possible https://github.com/airbnb/caravel/blob/master/caravel/viz.py#L2031

@mistercrunch
Copy link
Member

You can just override this in array in your caravel_config.py
https://github.com/airbnb/caravel/blob/master/caravel/config.py#L162

@kristw
Copy link
Contributor

kristw commented Dec 24, 2018

Closing this due to being very old issue. The recent work on #5680 and #5692 reflect similar ideas.

@kristw kristw closed this as completed Dec 24, 2018
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
* refactor: replace yarn with npm

* revert npm requirement back to 14 for vercel

* disable build Storybook job

* fix linting errors

* update lock file

* rebase master and bump encodable/color to 1.1.1

* update package-lock.json

update lock file

* change node version format to satisfy vercel

* remove restriction on @encodable/color

* rename yarn.lock to package-lock.json

* add resolved in lock file and restriction on @encodable/color

* install dependences by npm ci

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
* refactor: replace yarn with npm

* revert npm requirement back to 14 for vercel

* disable build Storybook job

* fix linting errors

* update lock file

* rebase master and bump encodable/color to 1.1.1

* update package-lock.json

update lock file

* change node version format to satisfy vercel

* remove restriction on @encodable/color

* rename yarn.lock to package-lock.json

* add resolved in lock file and restriction on @encodable/color

* install dependences by npm ci

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
* refactor: replace yarn with npm

* revert npm requirement back to 14 for vercel

* disable build Storybook job

* fix linting errors

* update lock file

* rebase master and bump encodable/color to 1.1.1

* update package-lock.json

update lock file

* change node version format to satisfy vercel

* remove restriction on @encodable/color

* rename yarn.lock to package-lock.json

* add resolved in lock file and restriction on @encodable/color

* install dependences by npm ci

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
* refactor: replace yarn with npm

* revert npm requirement back to 14 for vercel

* disable build Storybook job

* fix linting errors

* update lock file

* rebase master and bump encodable/color to 1.1.1

* update package-lock.json

update lock file

* change node version format to satisfy vercel

* remove restriction on @encodable/color

* rename yarn.lock to package-lock.json

* add resolved in lock file and restriction on @encodable/color

* install dependences by npm ci

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants