Skip to content

Commit

Permalink
chore(explore): Set Drag&Drop feature flags to True by default (#19046)
Browse files Browse the repository at this point in the history
* chore(explore): Set Drag&Drop feature flags to True by default

* fix tests
  • Loading branch information
kgabryje authored Mar 8, 2022
1 parent 4d96393 commit f9c7405
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('AdhocMetrics', () => {
.click();

cy.get('[data-test=metrics]')
.find('[data-test="add-metric-button"]')
.contains('Drop columns/metrics here or click')
.click();

// Title edit for saved metrics is disabled - switch to Simple
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,13 @@ describe('Groupby control', () => {
cy.visitChartByName('Num Births Trend');
cy.verifySliceSuccess({ waitAlias: '@chartData' });

cy.get('[data-test=groupby]').within(() => {
cy.get('.ant-select').click();
cy.get('input[type=search]').type('state{enter}');
});
cy.get('[data-test=groupby]')
.contains('Drop columns here or click')
.click();
cy.get('[id="adhoc-metric-edit-tabs-tab-simple"]').click();
cy.get('input[aria-label="Column"]').click().type('state{enter}');
cy.get('[data-test="ColumnEdit#save"]').contains('Save').click();

cy.get('button[data-test="run-query-button"]').click();
cy.verifySliceSuccess({ waitAlias: '@chartData', chartSelector: 'svg' });
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Visualization > Line', () => {
cy.get('.text-danger').contains('Metrics');

cy.get('[data-test=metrics]')
.find('[data-test="add-metric-button"]')
.contains('Drop columns/metrics here or click')
.click();

// Title edit for saved metrics is disabled - switch to Simple
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ const ColumnSelectPopover = ({
}
buttonSize="small"
onClick={onSave}
data-test="ColumnEdit#save"
cta
>
{t('Save')}
Expand Down
4 changes: 2 additions & 2 deletions superset/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,9 +417,9 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
# Enable experimental feature to search for other dashboards
"OMNIBAR": False,
"DASHBOARD_RBAC": False,
"ENABLE_EXPLORE_DRAG_AND_DROP": False,
"ENABLE_EXPLORE_DRAG_AND_DROP": True,
"ENABLE_FILTER_BOX_MIGRATION": False,
"ENABLE_DND_WITH_CLICK_UX": False,
"ENABLE_DND_WITH_CLICK_UX": True,
# Enabling ALERTS_ATTACH_REPORTS, the system sends email and slack message
# with screenshot and link
# Disables ALERTS_ATTACH_REPORTS, the system DOES NOT generate screenshot
Expand Down

0 comments on commit f9c7405

Please sign in to comment.