fix: KeyError 'sql' when opening a Trino virtual dataset (#30339)

apache · Sep 19, 2024 · ef9e5e5 · ef9e5e5
1 parent 9b87ca9
commit ef9e5e5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/superset/commands/sql_lab/execute.py b/superset/commands/sql_lab/execute.py
@@ -17,7 +17,6 @@
 # pylint: disable=too-few-public-methods, too-many-arguments
 from __future__ import annotations
 
-import copy
 import logging
 from typing import Any, TYPE_CHECKING
 
@@ -152,8 +151,6 @@ def _run_sql_json_exec_from_scratch(self) -> SqlJsonExecutionStatus:
             self._validate_access(query)
             self._execution_context.set_query(query)
             rendered_query = self._sql_query_render.render(self._execution_context)
-            validate_rendered_query = copy.copy(query)
-            validate_rendered_query.sql = rendered_query
             self._set_query_limit_if_required(rendered_query)
             self._query_dao.update(
                 query, {"limit": self._execution_context.query.limit}

diff --git a/superset/sqllab/sql_json_executer.py b/superset/sqllab/sql_json_executer.py
@@ -90,7 +90,6 @@ def execute(
         rendered_query: str,
         log_params: dict[str, Any] | None,
     ) -> SqlJsonExecutionStatus:
-        print(">>> execute <<<")
         query_id = execution_context.query.id
         try:
             data = self._get_sql_results_with_timeout(
@@ -102,7 +101,6 @@ def execute(
             raise
         except Exception as ex:
             logger.exception("Query %i failed unexpectedly", query_id)
-            print(str(ex))
             raise SupersetGenericDBErrorException(
                 utils.error_msg_from_exception(ex)
             ) from ex