chore: move controlPanel into time_table (#18160)

apache · Jan 28, 2022 · ea2d668 · ea2d668
1 parent 7c937ca
commit ea2d668
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeControl.test.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeControl.test.tsx
@@ -33,7 +33,7 @@ import {
   EchartsTimeseriesChartPlugin,
 } from '@superset-ui/plugin-chart-echarts';
 import { LineChartPlugin } from '@superset-ui/preset-chart-xy';
-import TimeTableChartPlugin from '../../../../visualizations/TimeTable/TimeTableChartPlugin';
+import TimeTableChartPlugin from '../../../../visualizations/TimeTable';
 import VizTypeControl, { VIZ_TYPE_CONTROL_TEST_ID } from './index';
 
 jest.useFakeTimers();

diff --git a/superset-frontend/src/setup/setupPlugins.ts b/superset-frontend/src/setup/setupPlugins.ts
@@ -21,15 +21,12 @@ import MainPreset from '../visualizations/presets/MainPreset';
 import setupPluginsExtra from './setupPluginsExtra';
 
 import Separator from '../explore/controlPanels/Separator';
-import TimeTable from '../explore/controlPanels/TimeTable';
 
 export default function setupPlugins() {
   new MainPreset().register();
 
   // TODO: Remove these shims once the control panel configs are moved into the plugin package.
-  getChartControlPanelRegistry()
-    .registerValue('separator', Separator)
-    .registerValue('time_table', TimeTable);
+  getChartControlPanelRegistry().registerValue('separator', Separator);
 
   setupPluginsExtra();
 }
diff --git a/...nd/src/explore/controlPanels/TimeTable.js → .../visualizations/TimeTable/controlPanel.js b/...nd/src/explore/controlPanels/TimeTable.js → .../visualizations/TimeTable/controlPanel.js
diff --git a/...zations/TimeTable/TimeTableChartPlugin.ts → ...end/src/visualizations/TimeTable/index.ts b/...zations/TimeTable/TimeTableChartPlugin.ts → ...end/src/visualizations/TimeTable/index.ts
@@ -19,6 +19,7 @@
 import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import transformProps from './transformProps';
 import thumbnail from './images/thumbnail.png';
+import controlPanel from './controlPanel';
 
 const metadata = new ChartMetadata({
   category: t('Table'),
@@ -45,6 +46,7 @@ export default class TimeTableChartPlugin extends ChartPlugin {
       metadata,
       transformProps,
       loadChart: () => import('./TimeTable'),
+      controlPanel,
     });
   }
 }
diff --git a/superset-frontend/src/visualizations/presets/MainPreset.js b/superset-frontend/src/visualizations/presets/MainPreset.js
@@ -79,7 +79,7 @@ import {
 } from 'src/filters/components/';
 import { PivotTableChartPlugin as PivotTableChartPluginV2 } from '@superset-ui/plugin-chart-pivot-table';
 import FilterBoxChartPlugin from '../FilterBox/FilterBoxChartPlugin';
-import TimeTableChartPlugin from '../TimeTable/TimeTableChartPlugin';
+import TimeTableChartPlugin from '../TimeTable';
 
 export default class MainPreset extends Preset {
   constructor() {