chore: use util test env for init check (#23325)

apache · Mar 13, 2023 · e42c2a7 · e42c2a7
1 parent 29e36b4
commit e42c2a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/superset-python-unittest.yml b/.github/workflows/superset-python-unittest.yml
@@ -50,6 +50,8 @@ jobs:
             mkdir ${{ github.workspace }}/.temp
       - name: Python unit tests
         if: steps.check.outcome == 'failure'
+        env:
+          SUPERSET_TESTENV: true
         run: |
           pytest --durations-min=0.5 --cov-report= --cov=superset ./tests/common ./tests/unit_tests --cache-clear
       - name: Upload code coverage

diff --git a/superset/initialization/__init__.py b/superset/initialization/__init__.py
@@ -53,7 +53,7 @@
 from superset.security import SupersetSecurityManager
 from superset.superset_typing import FlaskResponse
 from superset.tags.core import register_sqla_event_listeners
-from superset.utils.core import pessimistic_connection_handling
+from superset.utils.core import is_test, pessimistic_connection_handling
 from superset.utils.log import DBEventLogger, get_event_logger_from_cfg_value
 
 if TYPE_CHECKING:
@@ -457,8 +457,7 @@ def log_default_secret_key_warning() -> None:
             if (
                 self.superset_app.debug
                 or self.superset_app.config["TESTING"]
-                # There must be a better way
-                or "pytest" in sys.modules
+                or is_test()
             ):
                 logger.warning("Debug mode identified with default secret key")
                 log_default_secret_key_warning()