Skip to content

Commit

Permalink
fix: DML failures in SQL Lab (#25190)
Browse files Browse the repository at this point in the history
  • Loading branch information
hughhhh authored Sep 6, 2023
1 parent d030544 commit d849642
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions superset/sql_lab.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ def execute_sql_statement( # pylint: disable=too-many-arguments,too-many-statem
)

sql = parsed_query.stripped()

# This is a test to see if the query is being
# limited by either the dropdown or the sql.
# We are testing to see if more rows exist than the limit.
Expand Down Expand Up @@ -512,8 +513,13 @@ def execute_sql_statements(
ex, query, session, payload, prefix_message
)
return payload
# Commit the connection so CTA queries will create the table.
if apply_ctas:

# Commit the connection so CTA queries will create the table and any DML.
should_commit = (
not db_engine_spec.is_select_query(parsed_query) # check if query is DML
or apply_ctas
)
if should_commit:
conn.commit()

# Success, updating the query entry in database
Expand Down

0 comments on commit d849642

Please sign in to comment.