Skip to content

Commit

Permalink
perf(dashboards): improve API performance for dashboards (#9704)
Browse files Browse the repository at this point in the history
  • Loading branch information
dpgaspar authored May 5, 2020
1 parent 11972ed commit d373cc8
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ cryptography==2.8 # via apache-superset (setup.py)
dataclasses==0.6 # via apache-superset (setup.py)
decorator==4.4.1 # via retry
defusedxml==0.6.0 # via python3-openid
flask-appbuilder==2.3.2 # via apache-superset (setup.py)
flask-appbuilder==2.3.4 # via apache-superset (setup.py)
flask-babel==1.0.0 # via flask-appbuilder
flask-caching==1.8.0 # via apache-superset (setup.py)
flask-compress==1.4.0 # via apache-superset (setup.py)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def get_git_sha():
"cryptography>=2.4.2",
"dataclasses<0.7",
"flask>=1.1.0, <2.0.0",
"flask-appbuilder>=2.3.2, <2.4.0",
"flask-appbuilder>=2.3.4, <2.4.0",
"flask-caching",
"flask-compress",
"flask-talisman",
Expand Down
18 changes: 12 additions & 6 deletions superset/dashboards/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,26 @@ class DashboardRestApi(BaseSupersetModelRestApi):
]
order_columns = ["dashboard_title", "changed_on", "published", "changed_by_fk"]
list_columns = [
"id",
"published",
"slug",
"url",
"css",
"position_json",
"json_metadata",
"thumbnail_url",
"changed_by.first_name",
"changed_by.last_name",
"changed_by.username",
"changed_by.id",
"changed_by_name",
"changed_by_url",
"changed_by.username",
"changed_on",
"dashboard_title",
"owners.id",
"owners.username",
"owners.first_name",
"owners.last_name",
"id",
"published",
"slug",
"url",
"thumbnail_url",
]
edit_columns = [
"dashboard_title",
Expand Down

0 comments on commit d373cc8

Please sign in to comment.