-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(sqllab): Updated blank states for query results and query history (…
…#19111) * Empty states updated on result tab and query history tab * Testing on query history blank state * Testing on result tab with empty state * Forgot to remove a comment * Corrected empty state image size and centered with drag bar * Centered blank states vertically
- Loading branch information
1 parent
3d66912
commit bb618a4
Showing
4 changed files
with
134 additions
and
7 deletions.
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
superset-frontend/src/SqlLab/components/QueryHistory/QueryHistory.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
import React from 'react'; | ||
import { render, screen } from 'spec/helpers/testing-library'; | ||
import QueryHistory from 'src/SqlLab/components/QueryHistory'; | ||
|
||
const NOOP = () => {}; | ||
const mockedProps = { | ||
queries: [], | ||
actions: { | ||
queryEditorSetSql: NOOP, | ||
cloneQueryToNewTab: NOOP, | ||
fetchQueryResults: NOOP, | ||
clearQueryResults: NOOP, | ||
removeQuery: NOOP, | ||
}, | ||
displayLimit: 1000, | ||
}; | ||
|
||
const setup = (overrides = {}) => ( | ||
<QueryHistory {...mockedProps} {...overrides} /> | ||
); | ||
|
||
describe('QueryHistory', () => { | ||
it('Renders an empty state for query history', () => { | ||
render(setup()); | ||
|
||
const emptyStateText = screen.getByText( | ||
/run a query to display query history/i, | ||
); | ||
|
||
expect(emptyStateText).toBeVisible(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters