feedback implemented

tests/integration_tests/core_tests.py

@@ -1549,28 +1549,26 @@ def test_dashboard_injected_exceptions(self, mock_db_connection_mutator):
         self.assertIn("Error message", data)
 
     @mock.patch("superset.sql_lab.cancel_query")
-    def test_stop_query_no_cancel_query(self, mock_sql_lab_cancel_query):
+    @mock.patch("superset.views.core.db.session")
+    def test_stop_query_not_implemented(
+        self, mock_superset_db_session, mock_sql_lab_cancel_query
+    ):
         """
         Handles stop query when the DB engine spec does not
         have a cancel query method.
         """
         form_data = {"client_id": "foo"}
         query_mock = mock.Mock()
-        query_mock.sql = "SELECT *"
-        query_mock.database = 1
-        query_mock.schema = "superset"
         query_mock.client_id = "foo"
         query_mock.status = QueryStatus.RUNNING
         self.login(username="admin")
+        mock_superset_db_session.query().filter_by().one().return_value = query_mock
+        mock_sql_lab_cancel_query.return_value = False
+        rv = self.client.post(
+            "/superset/stop_query/", data={"form_data": json.dumps(form_data)},
+        )
 
-        with mock.patch("superset.views.core.db") as mock_superset_db:
-            mock_superset_db.session.query().filter_by().one().return_value = query_mock
-            mock_sql_lab_cancel_query.return_value = False
-            rv = self.client.post(
-                "/superset/stop_query/", data={"form_data": json.dumps(form_data)},
-            )
-
-        self.assertEqual(rv.status_code, 422)
+        assert rv.status_code == 422
 
 
 if __name__ == "__main__":