fix: dataset import error message (#23025)

apache · Feb 8, 2023 · 7bb9b81 · 7bb9b81
1 parent 98bf878
commit 7bb9b81
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/superset/commands/importers/v1/__init__.py b/superset/commands/importers/v1/__init__.py
@@ -67,6 +67,9 @@ def run(self) -> None:
         try:
             self._import(db.session, self._configs, self.overwrite)
             db.session.commit()
+        except CommandException as ex:
+            db.session.rollback()
+            raise ex
         except Exception as ex:
             db.session.rollback()
             raise self.import_error() from ex

diff --git a/superset/datasets/commands/exceptions.py b/superset/datasets/commands/exceptions.py
@@ -193,5 +193,5 @@ class DatasetDuplicateFailedError(CreateFailedError):
     message = _("Dataset could not be duplicated.")
 
 
-class DatasetForbiddenDataURI(ForbiddenError):
+class DatasetForbiddenDataURI(ImportFailedError):
     message = _("Data URI is not allowed.")