-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(dashboard): Cross-filters not working properly for new dashboards (…
- Loading branch information
Showing
4 changed files
with
288 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
207 changes: 207 additions & 0 deletions
207
superset-frontend/src/dashboard/util/crossFilters.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import sinon from 'sinon'; | ||
| import { Behavior, FeatureFlag } from '@superset-ui/core'; | ||
| import * as core from '@superset-ui/core'; | ||
| import { getCrossFiltersConfiguration } from './crossFilters'; | ||
|
|
||
| const DASHBOARD_LAYOUT = { | ||
| 'CHART-1': { | ||
| children: [], | ||
| id: 'CHART-1', | ||
| meta: { | ||
| chartId: 1, | ||
| sliceName: 'Test chart 1', | ||
| height: 1, | ||
| width: 1, | ||
| uuid: '1', | ||
| }, | ||
| parents: ['ROOT_ID', 'GRID_ID', 'ROW-6XUMf1rV76'], | ||
| type: 'CHART', | ||
| }, | ||
| 'CHART-2': { | ||
| children: [], | ||
| id: 'CHART-2', | ||
| meta: { | ||
| chartId: 2, | ||
| sliceName: 'Test chart 2', | ||
| height: 1, | ||
| width: 1, | ||
| uuid: '2', | ||
| }, | ||
| parents: ['ROOT_ID', 'GRID_ID', 'ROW-6XUMf1rV76'], | ||
| type: 'CHART', | ||
| }, | ||
| }; | ||
|
|
||
| const CHARTS = { | ||
| '1': { | ||
| id: 1, | ||
| form_data: { | ||
| datasource: '2__table', | ||
| viz_type: 'echarts_timeseries_line', | ||
| slice_id: 1, | ||
| }, | ||
| chartAlert: null, | ||
| chartStatus: 'rendered' as const, | ||
| chartUpdateEndTime: 0, | ||
| chartUpdateStartTime: 0, | ||
| lastRendered: 0, | ||
| latestQueryFormData: {}, | ||
| sliceFormData: { | ||
| datasource: '2__table', | ||
| viz_type: 'echarts_timeseries_line', | ||
| }, | ||
| queryController: null, | ||
| queriesResponse: [{}], | ||
| triggerQuery: false, | ||
| }, | ||
| '2': { | ||
| id: 2, | ||
| form_data: { | ||
| datasource: '2__table', | ||
| viz_type: 'echarts_timeseries_line', | ||
| slice_id: 2, | ||
| }, | ||
| chartAlert: null, | ||
| chartStatus: 'rendered' as const, | ||
| chartUpdateEndTime: 0, | ||
| chartUpdateStartTime: 0, | ||
| lastRendered: 0, | ||
| latestQueryFormData: {}, | ||
| sliceFormData: { | ||
| datasource: '2__table', | ||
| viz_type: 'echarts_timeseries_line', | ||
| }, | ||
| queryController: null, | ||
| queriesResponse: [{}], | ||
| triggerQuery: false, | ||
| }, | ||
| }; | ||
|
|
||
| const INITIAL_CHART_CONFIG = { | ||
| '1': { | ||
| id: 1, | ||
| crossFilters: { | ||
| scope: { | ||
| rootPath: ['ROOT_ID'], | ||
| excluded: [1], | ||
| }, | ||
| chartsInScope: [2], | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| test('Generate correct cross filters configuration without initial configuration', () => { | ||
| // @ts-ignore | ||
| global.featureFlags = { | ||
| [FeatureFlag.DASHBOARD_CROSS_FILTERS]: true, | ||
| }; | ||
| const metadataRegistryStub = sinon | ||
| .stub(core, 'getChartMetadataRegistry') | ||
| .callsFake(() => ({ | ||
| // @ts-ignore | ||
| get: () => ({ | ||
| behaviors: [Behavior.INTERACTIVE_CHART], | ||
| }), | ||
| })); | ||
| expect( | ||
| getCrossFiltersConfiguration(DASHBOARD_LAYOUT, undefined, CHARTS), | ||
| ).toEqual({ | ||
| '1': { | ||
| id: 1, | ||
| crossFilters: { | ||
| scope: { | ||
| rootPath: ['ROOT_ID'], | ||
| excluded: [1], | ||
| }, | ||
| chartsInScope: [2], | ||
| }, | ||
| }, | ||
| '2': { | ||
| id: 2, | ||
| crossFilters: { | ||
| scope: { | ||
| rootPath: ['ROOT_ID'], | ||
| excluded: [2], | ||
| }, | ||
| chartsInScope: [1], | ||
| }, | ||
| }, | ||
| }); | ||
| metadataRegistryStub.restore(); | ||
| }); | ||
|
|
||
| test('Generate correct cross filters configuration with initial configuration', () => { | ||
| // @ts-ignore | ||
| global.featureFlags = { | ||
| [FeatureFlag.DASHBOARD_CROSS_FILTERS]: true, | ||
| }; | ||
| const metadataRegistryStub = sinon | ||
| .stub(core, 'getChartMetadataRegistry') | ||
| .callsFake(() => ({ | ||
| // @ts-ignore | ||
| get: () => ({ | ||
| behaviors: [Behavior.INTERACTIVE_CHART], | ||
| }), | ||
| })); | ||
| expect( | ||
| getCrossFiltersConfiguration( | ||
| DASHBOARD_LAYOUT, | ||
| INITIAL_CHART_CONFIG, | ||
| CHARTS, | ||
| ), | ||
| ).toEqual({ | ||
| '1': { | ||
| id: 1, | ||
| crossFilters: { | ||
| scope: { | ||
| rootPath: ['ROOT_ID'], | ||
| excluded: [1], | ||
| }, | ||
| chartsInScope: [2], | ||
| }, | ||
| }, | ||
| '2': { | ||
| id: 2, | ||
| crossFilters: { | ||
| scope: { | ||
| rootPath: ['ROOT_ID'], | ||
| excluded: [2], | ||
| }, | ||
| chartsInScope: [1], | ||
| }, | ||
| }, | ||
| }); | ||
| metadataRegistryStub.restore(); | ||
| }); | ||
|
|
||
| test('Return undefined if DASHBOARD_CROSS_FILTERS feature flag is disabled', () => { | ||
| // @ts-ignore | ||
| global.featureFlags = { | ||
| [FeatureFlag.DASHBOARD_CROSS_FILTERS]: false, | ||
| }; | ||
| expect( | ||
| getCrossFiltersConfiguration( | ||
| DASHBOARD_LAYOUT, | ||
| INITIAL_CHART_CONFIG, | ||
| CHARTS, | ||
| ), | ||
| ).toEqual(undefined); | ||
| }); |
Oops, something went wrong.