add perm for global db add

apache · Mar 4, 2022 · 2706935 · 2706935
1 parent 77063cc
commit 2706935
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/superset-frontend/src/views/components/MenuRight.tsx b/superset-frontend/src/views/components/MenuRight.tsx
@@ -85,7 +85,8 @@ const RightMenu = ({
   const canSql = findPermission('can_sqllab', 'Superset', roles);
   const canDashboard = findPermission('can_write', 'Dashboard', roles);
   const canChart = findPermission('can_write', 'Chart', roles);
-  const showActionDropdown = canSql || canChart || canDashboard;
+  const canDatabase = findPermission('can_write', 'Database', roles);
+  const showActionDropdown = canSql || canChart || canDashboard || canDatabase;
   const dropdownItems: MenuObjectProps[] = [
     {
       label: t('Data'),
@@ -94,12 +95,12 @@ const RightMenu = ({
         {
           label: t('Connect Database'),
           name: GlobalMenuDataOptions.DB_CONNECTION,
-          perm: true,
+          perm: canDatabase,
         },
         {
           label: t('Connect Google Sheet'),
           name: GlobalMenuDataOptions.GOOGLE_SHEETS,
-          perm: HAS_GSHEETS_INSTALLED,
+          perm: canDatabase && HAS_GSHEETS_INSTALLED,
         },
         {
           label: t('Upload a CSV'),