WW-5524 Fixup StrutsConverterFactory #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should delegate back to ObjectFactory#buildBean instead of directly calling Container#inject, otherwise overrides of buildBean in subclasses of ObjectFactory e.g. SpringObjectFactory are skipped; meaning that TypeConverters cannot make use of Spring dependency injection Fixes: https://issues.apache.org/jira/projects/WW/issues/WW-5524
lukaszlenart
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where StrutsConverterFactory was bypassing ObjectFactory subclass overrides (like SpringObjectFactory) by directly calling Container#inject instead of delegating to ObjectFactory#buildBean. This ensures TypeConverters can properly utilize Spring dependency injection.
- Changes dependency injection mechanism from Container#inject to ObjectFactory#buildBean
- Updates injection dependency from Container to ObjectFactory
- Adds missing @OverRide annotation for interface implementation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/main/java/org/apache/struts2/factory/StrutsConverterFactory.java
Show resolved
Hide resolved
Member
|
@MFAshby do you want to port this change into 6.x? |
Contributor
Author
Thanks for looking @lukaszlenart , I don't need this backporting for my current project (I'm migrating to 7.x) but others might find it useful. I leave the decision to you. |
Member
|
Cherry picked #1316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should delegate back to ObjectFactory#buildBean instead of directly calling Container#inject, otherwise overrides of buildBean in subclasses of ObjectFactory e.g. SpringObjectFactory are skipped; meaning that TypeConverters cannot make use of Spring dependency injection
Fixes: https://issues.apache.org/jira/projects/WW/issues/WW-5524