WW-5530 make DateConverter work for LocalDate and LocalTime #1223
Conversation
|
Thanks for the PR. Could you create a ticket in JIRA which will relate to this change? Thanks in advance! |
lukaszlenart
changed the title
|
Great, could you extend |
@bill-humblcloud do you have spare cycles to address this comment? |
|
I have modified XWorkConverterTest.testDateConversion() to include tests for LocalDate, LocalDateTime, and LocalTime. The tests seem to pass during the build process. I am new to GitHub, so I am working to figure out how to get those changes uploaded here (should've made notes the first time I did this). I will try to get that done in the next 24 hours (simultaneously working on a release of my own project, so I will do my best). |
|
You can edit the file in your fork here even directly via the web editor on Github, commit the changes and they should appear in the PR. |
|
I believe the pull request now looks as it should with the test changes included. Please let me know if you see things differently. Thanks for the help! |
|
Looks good |
2 participants
WW-5530
I found that the DateConverter class could not convert for java.time.LocalDate or java.time.LocalTime input—only java.time.LocalDateTime worked. The reason for this is that these types were not handled in the XWorkBasicConverter class; thus, they could not be properly directed to the DateConverter class. This simple patch fixes that deficiency. [This is my first pull request, so sorry if I've done anything wrong. I believe the online docs are somewhat out of date. ] Thanks.