WW-3714 Deprecate and repackage common APIs part 5 - #1084
Merged
Conversation
kusalk
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @Override | ||
| public String getText(String key, String defaultValue, List<?> args, ValueStack stack) { | ||
| return getTextProvider().getText(key, defaultValue, args, stack); |
Check failure
Code scanning / CodeQL
OGNL Expression Language statement with user-controlled input
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 17, 2024 06:16
89c0930 to
da0934f
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
2 times, most recently
from
October 17, 2024 06:36
bb459bf to
41792fc
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
3 times, most recently
from
October 17, 2024 08:32
882eb16 to
f908a32
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 17, 2024 08:36
54659ba to
cf24fd3
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 17, 2024 08:36
f908a32 to
717046f
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 17, 2024 09:09
cf24fd3 to
44855ca
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 17, 2024 09:10
717046f to
f8dc1ce
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 17, 2024 09:28
44855ca to
4b17882
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 17, 2024 09:29
f8dc1ce to
a874416
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 22, 2024 02:55
4b17882 to
ebedd73
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
2 times, most recently
from
October 22, 2024 05:55
1dea3d3 to
228d33e
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 22, 2024 06:02
08174b5 to
2757c23
Compare
kusalk
force-pushed
the
kusal-depr-apis-6
branch
from
October 22, 2024 06:02
228d33e to
deb6c09
Compare
|
lukaszlenart
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WW-3714
This PR deprecates and provides repackaged replacements for the following APIs, ahead of their permanent migration in Struts 7.0:
com.opensymphony.xwork2.ActionSupportcom.opensymphony.xwork2.interceptor.AbstractInterceptorcom.opensymphony.xwork2.interceptor.MethodFilterInterceptorcom.opensymphony.xwork2.interceptor.MethodFilterInterceptorUtilI've also added alternative constructors to the following class which should unblock certain unit tests:
com.opensymphony.xwork2.config.entities.InterceptorMappingNote that the techniques employed in this PR are slightly different to that of the previous PRs where we were working with interfaces rather than concrete classes. For example, I've taken care to preserve the class inheritance hierarchy of
com.opensymphony.xwork2.interceptor.MethodFilterInterceptorto ensure compatibility with any potential overriding classes. This necessitated that the implementation was duplicated rather than extending itsorg.apache.struts2counterpart.