WW-3714 Deprecate and repackage common APIs part 4 - #1083
Merged
Conversation
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 17, 2024 05:18
07ca408 to
e978d8f
Compare
kusalk
force-pushed
the
kusal-depr-apis-4
branch
from
October 17, 2024 06:22
421cce6 to
e7e0178
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 17, 2024 06:27
e978d8f to
bb459bf
Compare
kusalk
force-pushed
the
kusal-depr-apis-4
branch
from
October 17, 2024 06:36
e7e0178 to
f4dec59
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
2 times, most recently
from
October 17, 2024 08:36
54659ba to
cf24fd3
Compare
kusalk
force-pushed
the
kusal-depr-apis-4
branch
from
October 17, 2024 09:09
f4dec59 to
cc0038b
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 17, 2024 09:09
cf24fd3 to
44855ca
Compare
kusalk
force-pushed
the
kusal-depr-apis-4
branch
from
October 17, 2024 09:28
cc0038b to
688a8da
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 17, 2024 09:28
44855ca to
4b17882
Compare
kusalk
force-pushed
the
kusal-depr-apis-4
branch
from
October 22, 2024 02:55
688a8da to
14bd4b8
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 22, 2024 02:55
4b17882 to
ebedd73
Compare
kusalk
force-pushed
the
kusal-depr-apis-5
branch
from
October 22, 2024 06:02
08174b5 to
2757c23
Compare
|
kusalk
marked this pull request as ready for review
October 22, 2024 07:08
lukaszlenart
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WW-3714
This PR deprecates and provides a repackaged replacement for the following API, ahead of its permanent migration in Struts 7.0:
com.opensymphony.xwork2.util.ValueStackIt additionally does the same for the following Action marker interfaces:
com.opensymphony.xwork2.ModelDrivencom.opensymphony.xwork2.Preparablecom.opensymphony.xwork2.Unchainablecom.opensymphony.xwork2.Validateablecom.opensymphony.xwork2.interceptor.ScopedModelDrivencom.opensymphony.xwork2.interceptor.ValidationAwarecom.opensymphony.xwork2.interceptor.ValidationErrorAwarecom.opensymphony.xwork2.interceptor.ValidationWorkflowAwarePlease refer to #1081 for the techniques and methodology employed in this PR.
With respect to the Action marker interfaces, it is necessary to replace the imports for these types wherever they are employed in an
instanceofcheck within Struts internal code such as interceptors. Since the deprecatedcom.opensymphony.xwork2types extend the neworg.apache.struts2type, by ensuring anyinstanceofchecks use the new type, it will function correctly for both marker interface variations.