-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1113] Added buttons to start and stop all adapters #1441
Conversation
Hi, @dominikriemer and @tenthe, could you please review this PR? Please let me know if anything needs to be changed or added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @purplesmurf45!
I did a rough first review and raised a few questions :-)
ui/src/app/connect/dialog/start-all-adapters/start-all-adapters-dialog.component.ts
Outdated
Show resolved
Hide resolved
ui/src/app/connect/dialog/start-all-adapters/start-all-adapters-dialog.component.ts
Outdated
Show resolved
Hide resolved
ui/src/app/connect/dialog/start-all-adapters/start-all-adapters-dialog.component.ts
Outdated
Show resolved
Hide resolved
ui/src/app/connect/dialog/start-all-adapters/start-all-adapters-dialog.component.ts
Outdated
Show resolved
Hide resolved
@dominikriemer I have made the requested changes. Can you please check now? Let me know if anything else needs revising! |
Hello @purplesmurf45,
You can find a sample test in [1]. [1] https://github.com/apache/streampipes/blob/dev/ui/cypress/tests/adapter/editAdapter.smoke.spec.ts |
@tenthe @dominikriemer I have added cypress tests for the newly added buttons. Could you please review the latest changes whenever you are free? |
@tenthe can you please have a look at the tests? |
@purplesmurf45 thanks a lot for this great PR. |
Purpose
As discussed in #1113, this PR adds
start all adapters
andstop all adapters
buttons on the connect page, similar to thestart all pipelines
andstop all pipelines
buttons on the pipelines page.Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no