Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sp 1132: Replace FileSet adapters with FileStream adapters in all e2e tests #1153

Merged
merged 6 commits into from
Jan 24, 2023

Conversation

tenthe
Copy link
Contributor

@tenthe tenthe commented Jan 24, 2023

Purpose

This PR fixes #1132 by removing all File Set adapter references and replacing them with a file stream adapter

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@tenthe tenthe added the testing Relates to any kind of test (unit test, integration, or E2E test). label Jan 24, 2023
@@ -1,2 +0,0 @@
timestamp;value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file intended to be empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, yes ;)
Thanks for the Review

@tenthe tenthe merged commit 8b079f0 into dev Jan 24, 2023
@tenthe tenthe deleted the SP-1132 branch January 24, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update e2e tests to use FileStream adapter instead of FileSet
3 participants