-
Notifications
You must be signed in to change notification settings - Fork 4.1k
MINOR : Add s390x support for Travis #3187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, any updates on the PR if the changes can be merged? |
install: /bin/bash ./dev-tools/travis/travis-install.sh `pwd` | ||
script: | ||
- /bin/bash ./dev-tools/travis/travis-script.sh `pwd` $MODULES | ||
- if [[ $(uname -m) != 's390x' ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not build all modules on s390x as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kishorvpatil ,
"travis-script.sh" contains tests for each of the MODULES and for some of the tests rocksdb is required. Currently there is no support for rocksdb for s390x. Found a PR raised to add s390x support to rocksdb (link) , waiting for it to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis build has been failing. Might be related to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ethanlm all builds have passed now.
Can you please prefix the title and commit with MINOR to suggest this is a minor change. |
44ef2b0
to
8e8fca0
Compare
Hi @kishorvpatil , currently there is no support for rocksdb for s390x which is required to run the MODULES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for the contribution. |
Hi @Ethanlm . Yes, we already build and maintain Apache Storm on s390x. Our build instructions are published here . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks
@sangitanalkar Thanks. I merged this to master. |
As Travis CI officially supports s390x builds, adding support for building Apache storm for s390x in travis.