Skip to content

Conversation

sangitanalkar
Copy link
Contributor

As Travis CI officially supports s390x builds, adding support for building Apache storm for s390x in travis.

@sangitanalkar
Copy link
Contributor Author

Hi, any updates on the PR if the changes can be merged?

install: /bin/bash ./dev-tools/travis/travis-install.sh `pwd`
script:
- /bin/bash ./dev-tools/travis/travis-script.sh `pwd` $MODULES
- if [[ $(uname -m) != 's390x' ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not build all modules on s390x as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kishorvpatil ,
"travis-script.sh" contains tests for each of the MODULES and for some of the tests rocksdb is required. Currently there is no support for rocksdb for s390x. Found a PR raised to add s390x support to rocksdb (link) , waiting for it to be merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis build has been failing. Might be related to this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ethanlm all builds have passed now.

@kishorvpatil
Copy link
Contributor

Can you please prefix the title and commit with MINOR to suggest this is a minor change.

@sangitanalkar sangitanalkar changed the title Add s390x support for Travis MINOR : Add s390x support for Travis Jan 17, 2020
@sangitanalkar
Copy link
Contributor Author

Hi @kishorvpatil , currently there is no support for rocksdb for s390x which is required to run the MODULES.
Can you please let us know if we can go ahead with this PR?

Copy link
Contributor

@kishorvpatil kishorvpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ethanlm
Copy link
Contributor

Ethanlm commented Jan 27, 2020

Thanks for the contribution.
My question on this is: Is anyone using s390x for Storm? If anything fails on s390x, somebody needs to spend time debugging. It would not be straightforward to me since I use amd64 only. I wonder if it's worth doing it. Thanks

@sangitanalkar
Copy link
Contributor Author

My question on this is: Is anyone using s390x for Storm? If anything fails on s390x, somebody needs to spend time debugging. It would not be straightforward to me since I use amd64 only. I wonder if it's worth doing it. Thanks

Hi @Ethanlm . Yes, we already build and maintain Apache Storm on s390x. Our build instructions are published here .

Copy link
Contributor

@Ethanlm Ethanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks

@Ethanlm Ethanlm merged commit dc086fe into apache:master Jan 30, 2020
@Ethanlm
Copy link
Contributor

Ethanlm commented Jan 30, 2020

@sangitanalkar Thanks. I merged this to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants