Skip to content

[DOCUMENTATION] Fix minor doc error #9956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DOCUMENTATION] Fix minor doc error #9956

wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Nov 25, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46663 has finished for PR 9956 at commit 3c21b43.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Nov 25, 2015
View reviewed changes
docs/configuration.md
@@ -35,7 +35,7 @@ val sc = new SparkContext(conf)
{% endhighlight %}

Note that we can have more than 1 thread in local mode, and in cases like Spark Streaming, we may
actually require one to prevent any sort of starvation issues.
actually require more than 1 thread to prevent any sort of starvation issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tdas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change is correct, to my understanding. It also seems implied by the previous sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we need 1 for the receiver and 1 for running the jobs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. correct.

@andrewor14
Copy link
Contributor

Merging into master 1.6.

@asfgit asfgit closed this in 67b6732 Nov 25, 2015
asfgit pushed a commit that referenced this pull request Nov 25, 2015
@zjffdu
[DOCUMENTATION] Fix minor doc error
448208d 
Author: Jeff Zhang <zjffdu@apache.org>

Closes #9956 from zjffdu/dev_typo.

(cherry picked from commit 67b6732)
Signed-off-by: Andrew Or <andrew@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zjffdu @SparkQA @andrewor14 @rxin @tdas @srowen